Skip to content

Conversation

@axw
Copy link
Contributor

@axw axw commented Oct 9, 2025

Description

Add a component for otelcol for #13950

Link to tracking issue

None

Testing

N/A

Documentation

N/A

Add a component for otelcol, e.g. for
open-telemetry#13950
@axw axw requested a review from a team as a code owner October 9, 2025 23:53
@axw axw requested a review from mx-psi October 9, 2025 23:53
@codecov
Copy link

codecov bot commented Oct 10, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 91.64%. Comparing base (995bea5) to head (79f0111).
⚠️ Report is 9 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #13988      +/-   ##
==========================================
- Coverage   91.67%   91.64%   -0.03%     
==========================================
  Files         653      653              
  Lines       42559    42559              
==========================================
- Hits        39014    39002      -12     
- Misses       2736     2745       +9     
- Partials      809      812       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@axw
Copy link
Contributor Author

axw commented Oct 10, 2025

CI failure should be fixed by #13987

Copy link
Member

@mx-psi mx-psi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feels a bit weird to use the pkg/ prefix but I realize you are just trying to be consistent

@mx-psi mx-psi added this pull request to the merge queue Oct 10, 2025
@axw
Copy link
Contributor Author

axw commented Oct 10, 2025

Feels a bit weird to use the pkg/ prefix but I realize you are just trying to be consistent

@mx-psi I don't love it either tbqh, feels strange given that the components are not under a pkg/ directory. Might be worth a follow up across all of the components.

Merged via the queue into open-telemetry:main with commit dd42f50 Oct 10, 2025
60 of 61 checks passed
@github-actions github-actions bot added this to the next release milestone Oct 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants